-
Notifications
You must be signed in to change notification settings - Fork 113
Fix #1180: also look into outgoing header while propagating #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@fjtirado @ricardozanini I took the liberty to add some debug logs, I can set them to Trace or even remove them if you don't feel comfortable by having those |
...e/src/main/java/io/quarkiverse/openapi/generator/providers/BearerAuthenticationProvider.java
Fixed
Show fixed
Hide fixed
...quarkiverse/openapi/generator/providers/AbstractAuthenticationPropagationHeadersFactory.java
Outdated
Show resolved
Hide resolved
...quarkiverse/openapi/generator/providers/AbstractAuthenticationPropagationHeadersFactory.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/quarkiverse/openapi/generator/providers/BearerAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
fjtirado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some traces should be removed beyond the one reported by codeql
Great work @gabriel-farache!!!
Signed-off-by: gabriel-farache <[email protected]>
7a32ed5 to
cff9e4d
Compare
Yeah...I am only logging the header keys now and never a single header value |
gmunozfe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, excellent work @gabriel-farache !
|
FYI this will also needs to be backported to LTS |
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectHow to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2to backport the original PR to thequarkus2branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.
Fixes #1180
Fixes apache/incubator-kie-issues#1968